rustc: remove linker_private/linker_private_weak #12978
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the linker_private and linker_private_weak linkage attributes, they have been superseded by private and private_weak and have been removed in upstream LLVM in commit r203866.
Remove obsolete linkage types from the llvm::Linkage enum. The linkage types are no-ops and weren't used inside rustc anyway.
| @@ -59,8 +59,6 @@ pub enum Linkage { | |||
| ExternalWeakLinkage = 12, | |||
| GhostLinkage = 13, | |||
| CommonLinkage = 14, | |||
| LinkerPrivateLinkage = 15, | |||
| LinkerPrivateWeakLinkage = 16, | |||
There was a problem hiding this comment.
A few other linkages in this list are no longer supported (Ghost/DLLExport/DLLImport/AutoHideLinkage etc), just from reading the header file and seeing what has /**< Obsolete */ next to it.
Could you remove the other obsolete ones and add a comment as to why there are holes in this list?
There was a problem hiding this comment.
Sure, no problem. Removed in bnoordhuis/rust@5c51ef2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the linker_private and linker_private_weak linkage attributes,
they have been superseded by private and private_weak and have been
removed in upstream LLVM in commit r203866.