Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that keyword_ident lint doesn't trigger on 'r#kw lifetime #130489

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Ensure that keyword_ident lint doesn't trigger on 'r#kw lifetime #130489

merged 1 commit into from
Sep 18, 2024

Conversation

compiler-errors
Copy link
Member

Fixes #130486

@rustbot
Copy link
Collaborator

rustbot commented Sep 17, 2024

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 17, 2024
@jieyouxu jieyouxu assigned jieyouxu and unassigned davidtwco Sep 18, 2024
jieyouxu
jieyouxu approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jieyouxu
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 18, 2024

📌 Commit 5de89bb has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 18, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 18, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 18, 2024
@bors
Auto merge of rust-lang#130498 - matthiaskrgr:rollup-tg4d0zi, r=matth…
f6bcd09 
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#130116 (Implement a Method to Seal `DiagInner`'s Suggestions)
 - rust-lang#130489 (Ensure that `keyword_ident` lint doesn't trigger on `'r#kw` lifetime)
 - rust-lang#130491 (more crash tests)
 - rust-lang#130496 (Fix circular fn_sig queries to correct number of args for methods)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 32c4d41 into rust-lang:master Sep 18, 2024
6 checks passed
@rustbot rustbot added this to the 1.83.0 milestone Sep 18, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 18, 2024
@rust-timer
Unrolled build for rust-lang#130489
520e93e 
Rollup merge of rust-lang#130489 - compiler-errors:raw-lt-lint, r=jieyouxu

Ensure that `keyword_ident` lint doesn't trigger on `'r#kw` lifetime

Fixes rust-lang#130486
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.83.0
Development

Successfully merging this pull request may close these issues.

keyword_idents_2024 should not warn on raw lifetimes
5 participants
@compiler-errors @rustbot @jieyouxu @bors @davidtwco