Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use TotalEq for HashMap #13088

Merged
merged 1 commit into from
Mar 23, 2014
Merged

use TotalEq for HashMap #13088

merged 1 commit into from
Mar 23, 2014

Conversation

thestinger
Copy link
Contributor

Closes #5283

@@ -31,7 +31,7 @@ use std::slice::ImmutableVector;

mod table {
use std::clone::Clone;
use std::cmp::Eq;
use std::cmp::{Eq};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove braces

bors added a commit that referenced this pull request Mar 23, 2014
@bors bors closed this Mar 23, 2014
@bors bors merged commit 3829ac2 into rust-lang:master Mar 23, 2014
@thestinger thestinger deleted the hashmap branch March 26, 2014 00:04
JohnTitor pushed a commit to JohnTitor/rust that referenced this pull request Aug 30, 2022
Pop an error notification when flycheck can't be restarted
flip1995 pushed a commit to flip1995/rust that referenced this pull request Jul 25, 2024
Create lint passes using `Conf`

This slightly reduces the amount of code changes needed to add a config to a lint and makes things makes things more consistent between passes. A dependence on the config being a static reference is also added. This would only ever be a problem if multiple crates end up compiled in a single process.

Other changes include:
* Removing useless `#[derive(..)]`s
* Removing `#[must_use]` on lint pass constructors.
* Unified the parsing of the `DisallowedPath` struct in lint passes.
* Update `disallowed_types` and `await_holding_invalid` messages to be consistent with other disallowed lints.
* Remove the `(from clippy.toml)` message. I plan on having all the configured lints point to point to a span in `clippy.toml` which will be more useful.

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

std::hashmap should use TotalEq
3 participants