Remove support for decompressing dylib metadata

[bjorn3]

We haven't been compressing dylib metadata for a while now. Removing decompression support will regress error messages about an incompatible rustc version being used, but dylibs are pretty rare anyway.

Fixes rust-lang/rust-analyzer#18451

[rustbot]

r? @Nadrieril

rustbot has assigned @Nadrieril.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[rustbot]

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging.

cc @davidtwco, @wesleywiser

[bjorn3]

To be precise we stopped compressing dylib metadata in #113695.

[bjorn3]

@Veykril rust-analyzer can probably also remove the support it has in rust-analyzer-proc-macro-server at https://github.com/rust-lang/rust-analyzer/blob/1aac2c637b81c2565c68324450582018088aaee6/crates/proc-macro-srv/src/dylib/version.rs#L150

[rustbot]

rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead.

cc @rust-lang/rust-analyzer

[bjorn3]

When dylibs switched from compressed to uncompressed metadata the metadata version was set to 8, so anything older than version 8 can't be read anyway without support for compressed metadata.

[jieyouxu]

Thanks, this looks like a good cleanup to me.

[jieyouxu]

@bors r=jieyouxu,Veykril rollup=never (for easier bisection in case for whatever reason someone runs into this)

[bors]

📌 Commit 3cc0ba8 has been approved by jieyouxu,Veykril

It is now in the queue for this repository.

[jieyouxu]

Tagging this with compat relnotes just to be safe, but I don't really expect anyone to run into this.
@rustbot label +relnotes

[bors]

⌛ Testing commit 3cc0ba8 with merge 145f9cf...

[bors]

☀️ Test successful - checks-actions
Approved by: jieyouxu,Veykril
Pushing 145f9cf to master...

[rust-timer]

Finished benchmarking commit (145f9cf): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -1.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.7%	[-1.7%, -1.7%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-1.7%	[-1.7%, -1.7%]	1

Cycles

Results (secondary -1.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.5%	[-1.5%, -1.5%]	1
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 779.567s -> 779.851s (0.04%)
Artifact size: 334.97 MiB -> 334.92 MiB (-0.01%)