Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename -Zparse-only #133590

Merged
merged 2 commits into from
Nov 29, 2024
Merged

Rename -Zparse-only #133590

merged 2 commits into from
Nov 29, 2024

Conversation

nnethercote
Copy link
Contributor

It's a misleading name.

r? @estebank

@nnethercote
Rename -Zparse-only.
76adf05 
I was surprised to find that running with `-Zparse-only` only parses the
crate root file. Other files aren't parsed because that happens later
during expansion.

This commit renames the option and updates the help message to make this
clearer.
@nnethercote
Update -Zshow-span help message.
accdfa1 
To clarify how it works.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 28, 2024
@nnethercote
Copy link
Contributor Author

Individual commits have more details. Additional discussion on Zulip.

@estebank
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Nov 28, 2024

📌 Commit accdfa1 has been approved by estebank

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 28, 2024
jhpratt added a commit to jhpratt/rust that referenced this pull request Nov 28, 2024
@jhpratt
Rollup merge of rust-lang#133590 - nnethercote:rename-parse-only, r=e…
84cc0b0 
…stebank

Rename `-Zparse-only`

It's a misleading name.

r? `@estebank`
@jhpratt jhpratt mentioned this pull request Nov 28, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 29, 2024
@bors
Auto merge of rust-lang#133600 - jhpratt:rollup-ysf0ngv, r=jhpratt
0d02ce8 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#133466 (Fix typos in pin.rs)
 - rust-lang#133530 (Use consistent wording in docs, use is zero instead of is 0)
 - rust-lang#133565 (chore: fix 404 status URL)
 - rust-lang#133575 (Fix typo in RELEASES.md)
 - rust-lang#133577 (Document s390x machine access via community cloud)
 - rust-lang#133583 (Fix type (exit → exist))
 - rust-lang#133590 (Rename `-Zparse-only`)

Failed merges:

 - rust-lang#133584 (Update more 2024 tests to remove -Zunstable-options)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 29, 2024
@bors
Auto merge of rust-lang#133600 - jhpratt:rollup-ysf0ngv, r=jhpratt
96a53e3 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#133466 (Fix typos in pin.rs)
 - rust-lang#133530 (Use consistent wording in docs, use is zero instead of is 0)
 - rust-lang#133565 (chore: fix 404 status URL)
 - rust-lang#133575 (Fix typo in RELEASES.md)
 - rust-lang#133577 (Document s390x machine access via community cloud)
 - rust-lang#133583 (Fix type (exit → exist))
 - rust-lang#133590 (Rename `-Zparse-only`)

Failed merges:

 - rust-lang#133584 (Update more 2024 tests to remove -Zunstable-options)

r? `@ghost`
`@rustbot` modify labels: rollup
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 29, 2024
@Zalathar
Rollup merge of rust-lang#133590 - nnethercote:rename-parse-only, r=e…
fbbf3cd 
…stebank

Rename `-Zparse-only`

It's a misleading name.

r? ``@estebank``
@Zalathar Zalathar mentioned this pull request Nov 29, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 29, 2024
@bors
Auto merge of rust-lang#133609 - Zalathar:rollup-1825fa8, r=Zalathar
9e6d698 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#131323 (Support `clobber_abi` in AVR inline assembly)
 - rust-lang#133092 (Always set the deployment target when building std)
 - rust-lang#133134 (Don't use a SyntheticProvider for literally every type)
 - rust-lang#133538 (Better diagnostic for fn items in variadic functions)
 - rust-lang#133590 (Rename `-Zparse-only`)
 - rust-lang#133592 (Misc: better instructions for envrc, ignore `/build` instead of `build/`)
 - rust-lang#133608 (Revert rust-lang#133418 (Store coverage source regions as `Span`) due to regression rust-lang#133606)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 29, 2024
@matthiaskrgr
Rollup merge of rust-lang#133590 - nnethercote:rename-parse-only, r=e…
0bb4447 
…stebank

Rename `-Zparse-only`

It's a misleading name.

r? ```@estebank```
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 29, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 29, 2024
@bors
Auto merge of rust-lang#133612 - matthiaskrgr:rollup-mig5n45, r=matth…
7b1ae66 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#132782 (improvements on initial sysroot and libdir finding logics)
 - rust-lang#133134 (Don't use a SyntheticProvider for literally every type)
 - rust-lang#133466 (Fix typos in pin.rs)
 - rust-lang#133492 (bootstrap: allow skipping steps with start of path)
 - rust-lang#133501 (support revealing defined opaque post borrowck)
 - rust-lang#133530 (Use consistent wording in docs, use is zero instead of is 0)
 - rust-lang#133538 (Better diagnostic for fn items in variadic functions)
 - rust-lang#133590 (Rename `-Zparse-only`)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 29, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 29, 2024
@bors
Auto merge of rust-lang#133619 - matthiaskrgr:rollup-7ywaheb, r=matth…
0c4f3a4 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#132782 (improvements on initial sysroot and libdir finding logics)
 - rust-lang#133466 (Fix typos in pin.rs)
 - rust-lang#133492 (bootstrap: allow skipping steps with start of path)
 - rust-lang#133501 (support revealing defined opaque post borrowck)
 - rust-lang#133530 (Use consistent wording in docs, use is zero instead of is 0)
 - rust-lang#133538 (Better diagnostic for fn items in variadic functions)
 - rust-lang#133590 (Rename `-Zparse-only`)

r? `@ghost`
`@rustbot` modify labels: rollup
@dev-ardi
Copy link
Contributor

Is there a flag that actually does only the parsing (and the macro expansion)?

@bors bors merged commit ce52b7b into rust-lang:master Nov 29, 2024
6 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Nov 29, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 29, 2024
@rust-timer
Unrolled build for rust-lang#133590
a84ebd6 
Rollup merge of rust-lang#133590 - nnethercote:rename-parse-only, r=estebank

Rename `-Zparse-only`

It's a misleading name.

r? ````@estebank````
@estebank
Copy link
Contributor

Is there a flag that actually does only the parsing (and the macro expansion)?

-Zunpretty=expanded (the options are normal, identified, expanded, expanded,identified, expanded,hygiene, ast-tree, ast-tree,expanded, hir, hir,identified, hir,typed, hir-tree, thir-tree, thir-flat, mir, stable-mir, or mir-cfg) gives you the output you likely want.

@nnethercote
Copy link
Contributor Author

Is there a flag that actually does only the parsing (and the macro expansion)?

-Zno-analysis does only parsing, macro expansion, and name resolution. So no type checking, borrow checking, codegen, etc.

@nnethercote nnethercote deleted the rename-parse-only branch November 30, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@estebank estebank

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.85.0
Development

Successfully merging this pull request may close these issues.
5 participants
@nnethercote @estebank @bors @dev-ardi @rustbot