Update NonZero and NonNull to not field-project (per MCP#807)
#133651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
5 tasks
oli-obk
reviewed
Dec 2, 2024
scottmcm
force-pushed
the
nonnull-nonzero-no-field-projection
branch
from
d2d9fbd to
9301b5c
Compare
This comment was marked as outdated.
This comment was marked as outdated.
scottmcm
force-pushed
the
nonnull-nonzero-no-field-projection
branch
from
9301b5c to
7afce4f
Compare
|
Sorry, accidentally pushed a different version of this temporarily. Diff since your review, @oli-obk, is https://github.com/rust-lang/rust/compare/d2d9fbd5749fc9849d343e17f4fcfd5a9060201e..7afce4f06a56dc1344f54e179a0785b95700df5f |
scottmcm
removed
the
T-compiler
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 4, 2024
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#133651 (Update `NonZero` and `NonNull` to not field-project (per MCP#807)) - rust-lang#133764 (rustdoc: Rename `set_back_info` to `restore_module_data`.) - rust-lang#133784 (Fix MutVisitor's default implementations to visit Stmt's and BinOp's spans) - rust-lang#133798 (stop replacing bivariant args with `'static` when computing closure requirements) - rust-lang#133804 (Improve code for FileName retrieval in rustdoc) - rust-lang#133817 (Use `eprintln` instead of `println` in bootstrap/compiletest/tidy) Failed merges: - rust-lang#133810 (remove unnecessary `eval_verify_bound`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 4, 2024
Rollup merge of rust-lang#133651 - scottmcm:nonnull-nonzero-no-field-projection, r=oli-obk Update `NonZero` and `NonNull` to not field-project (per MCP#807) rust-lang/compiler-team#807 (comment) was accepted, so this is the first PR towards moving the library to not using field projections into `[rustc_layout_scalar_valid_range_*]` types. `NonZero` was already using `transmute` nearly everywhere, so there are very few changes to it. `NonNull` needed more changes, but they're mostly simple, changing `.pointer` to `.as_ptr()`. r? libs cc rust-lang#133324, which will tidy up some of the MIR from this a bit more, but isn't a blocker.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rust-lang/compiler-team#807 (comment) was accepted, so this is the first PR towards moving the library to not using field projections into
[rustc_layout_scalar_valid_range_*]types.NonZerowas already usingtransmutenearly everywhere, so there are very few changes to it.NonNullneeded more changes, but they're mostly simple, changing.pointerto.as_ptr().r? libs
cc #133324, which will tidy up some of the MIR from this a bit more, but isn't a blocker.