Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compiler: Set target_abi = "ilp32e" on all riscv32e targets #134358

Merged
merged 1 commit into from
Jan 26, 2025
Merged

compiler: Set target_abi = "ilp32e" on all riscv32e targets #134358

merged 1 commit into from
Jan 26, 2025
+10 −4

Conversation

workingjubilee
Copy link
Member

@workingjubilee workingjubilee commented Dec 15, 2024 •
edited
Loading

This allows compile-time configuration based on this. In the near future we should do this across all RISCV targets, probably, but this cfg is essential for building software usable on these targets, and they are tier 3 so it seems less of a concern to tweak their definition thusly.

cc @hegza

Effectively requested by @rmsyn in this Zulip thread: https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/riscv.20base.20ISA.20specifiers.20for.20conditional.20compilation/near/483836652

@rustbot
Copy link
Collaborator

rustbot commented Dec 15, 2024

r? @fmease

rustbot has assigned @fmease.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 15, 2024
@rustbot
Copy link
Collaborator

rustbot commented Dec 15, 2024

These commits modify compiler targets.
(See the Target Tier Policy.)

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@workingjubilee
Copy link
Member Author

oh right, okay I guess.

@workingjubilee
compiler: Set target_abi = "ilp32e" on all riscv32e targets
9a81dc9 
This allows compile-time configuration based on this.
In the near future we should do this across all RISCV targets, probably,
but this cfg is essential for building software usable on these targets.
@workingjubilee workingjubilee mentioned this pull request Dec 16, 2024
Open
@workingjubilee
Copy link
Member Author

hey, Embedded RISCV Team? Can you sign off on this and maybe also adopt these rv32e targets? @almindor @dkhayes117 @romancardenas @MabezDev @jessebraham @rmsyn

MabezDev
MabezDev approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I don't speak for the whole team, but I think we should be fine to maintain these along with the targets we already do.

@rmsyn
Copy link

rmsyn commented Jan 25, 2025

LGTM, too. Same as @MabezDev, I only speak for myself, but I bought a dev board specifically to help test riscv32e changes on real hardware.

@fmease
Copy link
Member

fmease commented Jan 25, 2025

Thanks all!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 25, 2025

📌 Commit 9a81dc9 has been approved by fmease

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 25, 2025
jhpratt added a commit to jhpratt/rust that referenced this pull request Jan 26, 2025
@jhpratt
Rollup merge of rust-lang#134358 - workingjubilee:configure-my-riscv-…
fe2e288 
…abi, r=fmease

compiler: Set `target_abi = "ilp32e"` on all riscv32e targets

This allows compile-time configuration based on this. In the near future we should do this across all RISCV targets, probably, but this cfg is essential for building software usable on these targets, and they are tier 3 so it seems less of a concern to tweak their definition thusly.
@jhpratt jhpratt mentioned this pull request Jan 26, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 26, 2025
@bors
Auto merge of rust-lang#136084 - jhpratt:rollup-4li30te, r=jhpratt
3034d71 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#133631 (Support QNX 7.1 with `io-sock`+libstd and QNX 8.0 (`no_std` only))
 - rust-lang#134358 (compiler: Set `target_abi = "ilp32e"` on all riscv32e targets)
 - rust-lang#135764 (Fix tests on LLVM 20)
 - rust-lang#135812 (Fix GDB `OsString` provider on Windows )
 - rust-lang#135842 (TRPL: more backward-compatible Edition changes)
 - rust-lang#135946 (Remove extra whitespace from rustdoc breadcrumbs for copypasting)
 - rust-lang#135953 (ci.py: check the return code in `run-local`)
 - rust-lang#136019 (Add an `unchecked_div` alias to the `Div<NonZero<_>>` impls)

Failed merges:

 - rust-lang#136037 (Mark all NuttX targets as tier 3 target and support the standard library)

r? `@ghost`
`@rustbot` modify labels: rollup
@jhpratt jhpratt mentioned this pull request Jan 26, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 26, 2025
@bors
Auto merge of rust-lang#136087 - jhpratt:rollup-tam1mzn, r=jhpratt
15c6f7e 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#133631 (Support QNX 7.1 with `io-sock`+libstd and QNX 8.0 (`no_std` only))
 - rust-lang#134358 (compiler: Set `target_abi = "ilp32e"` on all riscv32e targets)
 - rust-lang#135812 (Fix GDB `OsString` provider on Windows )
 - rust-lang#135842 (TRPL: more backward-compatible Edition changes)
 - rust-lang#135946 (Remove extra whitespace from rustdoc breadcrumbs for copypasting)
 - rust-lang#135953 (ci.py: check the return code in `run-local`)
 - rust-lang#136019 (Add an `unchecked_div` alias to the `Div<NonZero<_>>` impls)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit cecdb32 into rust-lang:master Jan 26, 2025
6 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Jan 26, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 26, 2025
@rust-timer
Unrolled build for rust-lang#134358
a2e754a 
Rollup merge of rust-lang#134358 - workingjubilee:configure-my-riscv-abi, r=fmease

compiler: Set `target_abi = "ilp32e"` on all riscv32e targets

This allows compile-time configuration based on this. In the near future we should do this across all RISCV targets, probably, but this cfg is essential for building software usable on these targets, and they are tier 3 so it seems less of a concern to tweak their definition thusly.
@workingjubilee workingjubilee deleted the configure-my-riscv-abi branch January 26, 2025 22:14
@workingjubilee workingjubilee mentioned this pull request Jan 26, 2025
Open
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmsyn rmsyn rmsyn approved these changes

@fmease fmease fmease approved these changes

@romancardenas romancardenas romancardenas approved these changes

@MabezDev MabezDev MabezDev approved these changes

@almindor almindor almindor approved these changes

Assignees

@fmease fmease

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.86.0
Development

Successfully merging this pull request may close these issues.
9 participants
@workingjubilee @rustbot @rust-log-analyzer @rmsyn @fmease @bors @almindor @MabezDev @romancardenas