Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootstrap: fix a comment #134409

Merged
merged 2 commits into from
Dec 17, 2024
Merged

bootstrap: fix a comment #134409

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ace653
bootstrap: fix a comment
RalfJung Dec 17, 2024
7dbfe4d
clarify that path() is for on-disk paths
RalfJung Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/bootstrap/src/core/builder/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -613,7 +613,9 @@ impl<'a> ShouldRun<'a> {
self
}

// single, non-aliased path
/// single, non-aliased path
///
/// Must be an on-disk path; use `alias` for names that do not correspond to on-disk paths.
pub fn path(self, path: &str) -> Self {
self.paths(&[path])
}
Expand All @@ -622,7 +624,7 @@ impl<'a> ShouldRun<'a> {
///
/// This differs from [`path`] in that multiple calls to path will end up calling `make_run`
/// multiple times, whereas a single call to `paths` will only ever generate a single call to
/// `paths`.
/// `make_run`.
///
/// This is analogous to `all_krates`, although `all_krates` is gone now. Prefer [`path`] where possible.
///
Expand Down
Loading