Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reference annotations for the coverage attribute #134487

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Dec 18, 2024

This adds reference annotations for the coverage attribute.

@rustbot
Copy link
Collaborator

rustbot commented Dec 18, 2024

r? @BoxyUwU

rustbot has assigned @BoxyUwU.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 18, 2024
@rustbot
Copy link
Collaborator

rustbot commented Dec 18, 2024

Some changes occurred in coverage tests.

cc @Zalathar

@compiler-errors
Copy link
Member

r=me when green unless you'd want a review from Zalathar

@jieyouxu jieyouxu added the A-code-coverage Area: Source-based code coverage (-Cinstrument-coverage) label Dec 19, 2024
@jieyouxu
Copy link
Member

This only adds "comments" effectively, so

@bors r=@compiler-errors rollup

@bors
Copy link
Contributor

bors commented Dec 19, 2024

📌 Commit dbf5ae3 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 19, 2024
@jieyouxu jieyouxu assigned compiler-errors and unassigned BoxyUwU Dec 19, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 19, 2024
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#134463 (compiletest: don't register predefined `MSVC`/`NONMSVC` FileCheck prefixes)
 - rust-lang#134487 (Add reference annotations for the `coverage` attribute)
 - rust-lang#134497 (coverage: Store coverage source regions as `Span` until codegen (take 2))
 - rust-lang#134502 (Update std libc version to 0.2.169)
 - rust-lang#134506 (Remove a duplicated check that doesn't do anything anymore.)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 19, 2024
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#134463 (compiletest: don't register predefined `MSVC`/`NONMSVC` FileCheck prefixes)
 - rust-lang#134487 (Add reference annotations for the `coverage` attribute)
 - rust-lang#134497 (coverage: Store coverage source regions as `Span` until codegen (take 2))
 - rust-lang#134502 (Update std libc version to 0.2.169)
 - rust-lang#134506 (Remove a duplicated check that doesn't do anything anymore.)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 19, 2024
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#134463 (compiletest: don't register predefined `MSVC`/`NONMSVC` FileCheck prefixes)
 - rust-lang#134487 (Add reference annotations for the `coverage` attribute)
 - rust-lang#134497 (coverage: Store coverage source regions as `Span` until codegen (take 2))
 - rust-lang#134502 (Update std libc version to 0.2.169)
 - rust-lang#134506 (Remove a duplicated check that doesn't do anything anymore.)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit fc11b5a into rust-lang:master Dec 20, 2024
6 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Dec 20, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 20, 2024
Rollup merge of rust-lang#134487 - ehuss:reference-coverage, r=compiler-errors

Add reference annotations for the `coverage` attribute

This adds reference annotations for the `coverage` attribute.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-code-coverage Area: Source-based code coverage (-Cinstrument-coverage) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants