Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use trait definition cycle detection for trait alias definitions, too #134504

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use trait definition cycle detection for trait alias definitions, too #134504

wants to merge 2 commits into from
+72 −8

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Dec 19, 2024 •
edited
Loading

fixes #133901

In general doing this for All is not right, but this code path is specifically for traits and trait aliases, and there we only ever use All for trait aliases.

@rustbot
Copy link
Collaborator

rustbot commented Dec 19, 2024

r? @compiler-errors

rustbot has assigned @compiler-errors.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 19, 2024
@oli-obk oli-obk changed the title Use trait defintion cycle detection for trait alias definitions, too Use trait definition cycle detection for trait alias definitions, too Dec 19, 2024
oli-obk added 2 commits January 9, 2025 08:49
@oli-obk
Harden Ty constructors a bit in debug mode
91b6b4e 
`Ty::new` wasn't used anywhere outside this module

`Ty::new_adt` shouldn't ever be used for anything but adts. This hasn't caught any bugs, but seems good to check anyway
@oli-obk
Use trait definition cycle detection for trait alias definitions, too
37f2998
@oli-obk oli-obk force-pushed the push-rltsvnyttwll branch from 6348c8f to 37f2998 Compare January 9, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hang from infinitely-self-recursive trait alias
3 participants
@oli-obk @rustbot @compiler-errors