nits: Cleanup of librustdoc::clean::Cfg::simplify_with

[poliorcetics]

r? @GuillaumeGomez

[GuillaumeGomez]

Thanks! Once CI is green, r=me.

@bors delegate=poliorcetics

[bors]

✌️ @poliorcetics, you can now approve this pull request!

If @GuillaumeGomez told you to "r=me" after making some further change, please make that change, then do @bors r=@GuillaumeGomez

[GuillaumeGomez]

@bors r+ rollup

[bors]

📌 Commit 8cf09c7 has been approved by GuillaumeGomez

It is now in the queue for this repository.

[bors]

⌛ Testing commit 8cf09c7 with merge dd843fa...

[rust-log-analyzer]

The job x86_64-msvc-ext1 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[bors]

💔 Test failed - checks-actions

[poliorcetics]

Failure was:

---- package::workspace_with_local_dep_already_published stdout ----
running `D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\release\cargo.exe package`
thread 'package::workspace_with_local_dep_already_published' panicked at src\tools\cargo\tests\testsuite\package.rs:6200:10:

test failed running `D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\release\cargo.exe package`
error: process exited with code 101 (expected 0)
--- stdout

--- stderr
   Packaging dep v0.1.0 (D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t2250\foo\dep)
    Packaged 4 files, 1.1KiB (723.0B compressed)
   Packaging main v0.0.1 (D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t2250\foo\main)
    Updating crates.io index
    Packaged 4 files, 1.5KiB (897.0B compressed)
   Verifying dep v0.1.0 (D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t2250\foo\dep)
   Compiling dep v0.1.0 (D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t2250\foo\target\package\dep-0.1.0)
error: couldn't create a temp dir: Access is denied. (os error 5) at path "D:\\a\\_temp\\msys64\\tmp\\rustcyEAdB6"

error: could not compile `dep` (lib) due to 1 previous error
error: failed to verify package tarball



failures:
    package::workspace_with_local_dep_already_published

test result: FAILED. 3305 passed; 1 failed; 246 ignored; 0 measured; 0 filtered out; finished in 473.07s

Completely unrelated to my changes I think ?

[GuillaumeGomez]

You could have retried, you have the rights too on this PR normally. ;)

@bors retry

[bors]

⌛ Testing commit 8cf09c7 with merge 7c002ff...

[bors]

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing 7c002ff to master...

[rust-timer]

Finished benchmarking commit (7c002ff): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (primary 2.0%, secondary 3.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.0%	[1.9%, 2.0%]	2
Regressions ❌ (secondary)	3.7%	[2.8%, 4.9%]	7
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.0%	[1.9%, 2.0%]	2

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 764.158s -> 764.604s (0.06%)
Artifact size: 330.54 MiB -> 330.49 MiB (-0.02%)