Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kl and widekl target features, and the feature gate #134814

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add kl and widekl target features, and the feature gate #134814

wants to merge 1 commit into from
+26 −0

Conversation

sayantn
Copy link
Contributor

@sayantn sayantn commented Dec 27, 2024 •
edited
Loading

This is an effort towards #134813. This PR adds the target-features and the feature gate to rustc

@rustbot label O-x86_64 O-x86_32 A-target-feature
r? compiler

@rustbot
Copy link
Collaborator

rustbot commented Dec 27, 2024

r? @BoxyUwU

rustbot has assigned @BoxyUwU.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 27, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Jan 6, 2025

☔ The latest upstream changes (presumably #134794) made this pull request unmergeable. Please resolve the merge conflicts.

@rustbot rustbot added A-target-feature Area: Enabling/disabling target features like AVX, Neon, etc. O-x86_32 Target: x86 processors, 32 bit (like i686-*) O-x86_64 Target: x86-64 processors (like x86_64-*) labels Jan 8, 2025
@rustbot rustbot assigned jieyouxu and unassigned BoxyUwU Jan 8, 2025
@jieyouxu
Copy link
Member

jieyouxu commented Jan 8, 2025

r? compiler

@rustbot rustbot assigned fmease and unassigned jieyouxu Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fmease fmease

Labels
A-target-feature Area: Enabling/disabling target features like AVX, Neon, etc. O-x86_32 Target: x86 processors, 32 bit (like i686-*) O-x86_64 Target: x86-64 processors (like x86_64-*) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sayantn @rustbot @rust-log-analyzer @bors @jieyouxu @fmease @BoxyUwU