add suggestion for wrongly ordered format parameters #134877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @estebank (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
added
S-waiting-on-review
DavisRayM
commented
Dec 29, 2024
Comment on lines
+19
to
+20
| //~^ ERROR invalid format string: expected `}`, found `x` | ||
| //~| HELP did you mean `x?`? |
There was a problem hiding this comment.
I thought it made sense to return the same error description, expected '}'..., rather than introducing a new one, as it's the actual underlying error. I added a suggestion to reorder the format parameter if a #/x/X character is spotted afterward. However, I completely understand if the preference is to add a new error message similar to the approach taken in the previous PR this one replaces.
DavisRayM
force-pushed
the
129966-format-string-help-message
branch
from
e35719c to
62c3c9a
Compare
estebank
reviewed
Dec 31, 2024
| @@ -197,6 +197,8 @@ builtin_macros_format_redundant_args = redundant {$n -> | |||
|
|
|||
| builtin_macros_format_remove_raw_ident = remove the `r#` | |||
|
|
|||
| builtin_macros_format_reorder_format_parameter = did you mean `{$replacement}`? | |||
There was a problem hiding this comment.
For future reference, we prefer not to ask questions of the user anymore. If I were writing this message, I'd say something like "you might have meant to write #?".
|
@bors r+ |
bors
added
S-waiting-on-bors
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Jan 1, 2025
…p-message, r=estebank add suggestion for wrongly ordered format parameters Add suggestion for wrongly ordered format parameters like `?#`. Supersedes rust-lang#131004 Fix rust-lang#129966
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 1, 2025
Rollup of 7 pull requests Successful merges: - rust-lang#131439 (Remove allowing static_mut_refs lint) - rust-lang#133292 (E0277: suggest dereferencing function arguments in more cases) - rust-lang#134080 (Avoid use of LFS64 symbols on Emscripten) - rust-lang#134877 (add suggestion for wrongly ordered format parameters) - rust-lang#134926 (Update books) - rust-lang#134945 (Some small nits to the borrowck suggestions for mutating a map through index) - rust-lang#134979 (Provide structured suggestion for `impl Default` of type where all fields have defaults) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 1, 2025
Rollup of 6 pull requests Successful merges: - rust-lang#131439 (Remove allowing static_mut_refs lint) - rust-lang#133292 (E0277: suggest dereferencing function arguments in more cases) - rust-lang#134877 (add suggestion for wrongly ordered format parameters) - rust-lang#134945 (Some small nits to the borrowck suggestions for mutating a map through index) - rust-lang#134950 (bootstrap: Overhaul and simplify the `tool_check_step!` macro) - rust-lang#134979 (Provide structured suggestion for `impl Default` of type where all fields have defaults) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 1, 2025
Rollup merge of rust-lang#134877 - DavisRayM:129966-format-string-help-message, r=estebank add suggestion for wrongly ordered format parameters Add suggestion for wrongly ordered format parameters like `?#`. Supersedes rust-lang#131004 Fix rust-lang#129966
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add suggestion for wrongly ordered format parameters like
?#.Supersedes #131004
Fix #129966