Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Cleanup docker build logs in CI #134924

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

ranger-ross
Copy link
Contributor

@ranger-ross ranger-ross commented Dec 30, 2024

Cleaning up the CI logs to make reviewing CI failures easier. This PR adds a ::group around the docker tag hash input which is pretty large (250+ lines) and is probably not relevant for most people.

Related to #134910 , see this comment

@rustbot
Copy link
Collaborator

rustbot commented Dec 30, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Dec 30, 2024
@ranger-ross
Copy link
Contributor Author

Here is my testing proof from this CI run https://github.com/rust-lang/rust/actions/runs/12548637373/job/34988231645?pr=134924

Looks to be working as expected

image

@ranger-ross ranger-ross marked this pull request as ready for review December 30, 2024 15:40
@Kobzol
Copy link
Contributor

Kobzol commented Dec 30, 2024

Yeah, this was too verbose. Thank you!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 30, 2024

📌 Commit b4d14ce has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 30, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 30, 2024
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#132477 (Add illumos target documentation)
 - rust-lang#134871 (Add codegen test for issue 63646)
 - rust-lang#134911 (chore: fix typos)
 - rust-lang#134922 (Fix typos)
 - rust-lang#134924 (ci: Cleanup docker build logs in CI)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 05c0cd3 into rust-lang:master Dec 30, 2024
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 30, 2024
Rollup merge of rust-lang#134924 - ranger-ross:cleanup-ci-output, r=Kobzol

ci: Cleanup docker build logs in CI

Cleaning up the CI logs to make reviewing CI failures easier. This PR adds a `::group` around the docker tag hash input which is pretty large (250+ lines) and is probably not relevant for most people.

Related to rust-lang#134910 , see this [comment](rust-lang#134910 (comment))
@rustbot rustbot added this to the 1.85.0 milestone Dec 30, 2024
@ranger-ross ranger-ross deleted the cleanup-ci-output branch December 31, 2024 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants