Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure we check the future type is Sized in AsyncFn* #134933

Merged
merged 1 commit into from
Dec 31, 2024
Merged

Make sure we check the future type is Sized in AsyncFn* #134933

merged 1 commit into from
Dec 31, 2024

Conversation

compiler-errors
Copy link
Member

Fixes #134817

@rustbot
Copy link
Collaborator

rustbot commented Dec 30, 2024

r? @Noratrieb

rustbot has assigned @Noratrieb.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 30, 2024
@lqd
Copy link
Member

lqd commented Dec 30, 2024

could the mcve from the issue be added as a test?

@compiler-errors
Copy link
Member Author

Ya i just forgot to stage and commit it lol

lqd
lqd approved these changes Dec 30, 2024
View reviewed changes
Copy link
Member

@lqd lqd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with the test, and with the comment if possible (but fine without it)

compiler/rustc_trait_selection/src/traits/select/confirmation.rs Show resolved Hide resolved
@Noratrieb Noratrieb assigned lqd and unassigned Noratrieb Dec 30, 2024
@compiler-errors
Copy link
Member Author

@bors r=lqd rollup

@bors
Copy link
Contributor

bors commented Dec 31, 2024

📌 Commit ed9a4cf has been approved by lqd

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 31, 2024
@Zalathar Zalathar mentioned this pull request Dec 31, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 31, 2024
@bors
Auto merge of rust-lang#134952 - Zalathar:rollup-i6g97md, r=Zalathar
41b5796 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#134919 (bootstrap: Make `./x test compiler` actually run the compiler unit tests)
 - rust-lang#134927 (Make slice::as_flattened_mut unstably const)
 - rust-lang#134930 (ptr docs: make it clear that we are talking only about memory accesses)
 - rust-lang#134932 (explicitly set float ABI for all ARM targets)
 - rust-lang#134933 (Make sure we check the future type is `Sized` in `AsyncFn*`)
 - rust-lang#134934 (Fix typos)
 - rust-lang#134941 (compiler: Add a statement-of-intent to `rustc_abi`)
 - rust-lang#134949 (Convert some `Into` impls into `From` impls)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a93bef6 into rust-lang:master Dec 31, 2024
6 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Dec 31, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 31, 2024
@rust-timer
Unrolled build for rust-lang#134933
d8fee1e 
Rollup merge of rust-lang#134933 - compiler-errors:async-fn-future-sized, r=lqd

Make sure we check the future type is `Sized` in `AsyncFn*`

Fixes rust-lang#134817
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lqd lqd lqd approved these changes

Assignees

@lqd lqd

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.85.0
Development

Successfully merging this pull request may close these issues.

typing for async function pointer to generic function
5 participants
@compiler-errors @rustbot @lqd @bors @Noratrieb