Fix ICE when opaque captures a duplicated/invalid lifetime #135000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
lqd
approved these changes
Jan 1, 2025
There was a problem hiding this comment.
IIRC #131295 is not a dupe of the others so it shouldn't be fixed by this PR? Like, someone added an MCVE there by mistake that involved shadowing or something, like you've fixed here.
r=me with the blessed expectations + error annotation in the test, and the "fixes 131295" removed if it indeed shouldn't be present.
compiler-errors
force-pushed
the
opaque-captures-dupe
branch
from
b7a4dcc to
d3c6067
Compare
|
Changes to the size of AST and/or HIR nodes. cc @nnethercote |
|
@bors r=lqd rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 1, 2025
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#134967 (handle submodules automatically on `doc` steps) - rust-lang#134973 (Fix typos) - rust-lang#134984 (`ObligationCause` construction tweaks in typeck) - rust-lang#134985 (Remove qualification of `std::cmp::Ordering` in `Ord` doc) - rust-lang#135000 (Fix ICE when opaque captures a duplicated/invalid lifetime) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 2, 2025
Rollup merge of rust-lang#135000 - compiler-errors:opaque-captures-dupe, r=lqd Fix ICE when opaque captures a duplicated/invalid lifetime See description on test. Fixes rust-lang#132766 Fixes rust-lang#133693 Fixes rust-lang#134780
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See description on test.
Fixes #132766
Fixes #133693
Fixes #134780