Fix formatting command #135035
Merged
Fix formatting command #135035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The formatting command previously had two issues: - if rustfmt failed, it would print the command invocation. this is unnecessarily noisy - there was a race condition that lead to orphan rustfmts that would print their output after bootstrap exited We fix this by - removing the printing, it's not really useful - threading failure through properly instead of just yoloing exit(1)
|
rustbot has assigned @Mark-Simulacrum. Use |
rustbot
added
S-waiting-on-review
|
r=me after PR CI is slightly green |
|
mingw-check-tidy passed |
bors
added
S-waiting-on-bors
the8472
reviewed
Jan 2, 2025
| } | ||
| } | ||
|
|
||
| if children.len() >= max_processes { | ||
| // Await oldest child. | ||
| children.pop_front().unwrap()(true); | ||
| match children.pop_front().unwrap()(true) { | ||
| RustfmtStatus::InProgress | RustfmtStatus::Ok => {} |
There was a problem hiding this comment.
InProgress should be unreachable when passing block: true
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 2, 2025
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#135016 (Ping me for rustc-dev-guide subtree changes on this repo) - rust-lang#135027 (Remove range-metadata amdgpu workaround) - rust-lang#135029 (Update mailmap) - rust-lang#135033 (try to dedup me in the mailmap) - rust-lang#135035 (Fix formatting command) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 2, 2025
Rollup merge of rust-lang#135035 - Noratrieb:fixfmt, r=jieyouxu Fix formatting command The formatting command previously had two issues: - if rustfmt failed, it would print the command invocation. this is unnecessarily noisy - there was a race condition that lead to orphan rustfmts that would print their output after bootstrap exited We fix this by - removing the printing, it's not really useful - threading failure through properly instead of just yoloing exit(1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The formatting command previously had two issues:
We fix this by