Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include x scripts in tarballs #135612

Merged
merged 2 commits into from
Jan 18, 2025

Conversation

onur-ozkan
Copy link
Member

Helps to provide 1:1 build experience between git-managed and tarball sources.

@rustbot
Copy link
Collaborator

rustbot commented Jan 17, 2025

r? @Kobzol

rustbot has assigned @Kobzol.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jan 17, 2025
@onur-ozkan onur-ozkan force-pushed the include-x-scripts-in-tarballs branch from 0060535 to 44671c6 Compare January 17, 2025 08:21
@rust-log-analyzer

This comment has been minimized.

Helps to provide 1:1 build experience between git-managed and tarball sources.

Signed-off-by: onur-ozkan <[email protected]>
@onur-ozkan onur-ozkan force-pushed the include-x-scripts-in-tarballs branch from 44671c6 to fdf4924 Compare January 17, 2025 08:37
@clubby789
Copy link
Contributor

Seems helpful, thanks
@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 17, 2025

📌 Commit fdf4924 has been approved by clubby789

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 17, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 18, 2025
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#133700 (const-eval: detect more pointers as definitely not-null)
 - rust-lang#135290 (Encode constraints that hold at all points as logical edges in location-sensitive polonius)
 - rust-lang#135478 (Run clippy for rustc_codegen_gcc on CI)
 - rust-lang#135583 (Move `std::pipe::*` into `std::io`)
 - rust-lang#135612 (Include x scripts in tarballs)
 - rust-lang#135624 (ci: mirror buildkit image to ghcr)
 - rust-lang#135661 (Stabilize `float_next_up_down`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b0d0ec4 into rust-lang:master Jan 18, 2025
6 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Jan 18, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 18, 2025
Rollup merge of rust-lang#135612 - onur-ozkan:include-x-scripts-in-tarballs, r=clubby789

Include x scripts in tarballs

Helps to provide 1:1 build experience between git-managed and tarball sources.
@onur-ozkan onur-ozkan deleted the include-x-scripts-in-tarballs branch January 18, 2025 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants