Replace usages of map_or(bool, ...) with is_{some_and|none_or|ok_and}
#135732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustbot has assigned @petrochenkov. Use |
rustbot
added
A-tidy
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt Some changes occurred in coverage instrumentation. cc @Zalathar Some changes occurred to the CTFE / Miri interpreter cc @rust-lang/miri, @rust-lang/wg-const-eval |
compiler-errors
requested changes
Jan 19, 2025
There was a problem hiding this comment.
Please do not open PRs that apply clippy lints widely to all tools, standard library, and compiler. It makes it difficult to review, since different reviewers should and should not be approving changes to different parts of the compiler. If you'd like to, please split this into separate PRs for compiler/library/tidy.
|
Feel free to assign me the compiler PR, but for now I'm gonna close this. |
|
Will do, thanks and sorry for the noise. 🙏 |
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jan 19, 2025
…compiler-errors
Replace usages of `map_or(bool, ...)` with `is_{some_and|none_or|ok_and}`
Split out from rust-lang#135732 according to rust-lang#135732 ,
same thing but just for the compiler:
> The usage of `map_or(bool, ...)` is really hard to understand IMHO.
> This PR simply uses clippy (with `--fix`) to replace that with `is_{some_and|none_or|ok_and}`.
> (no manual modifications were made, just machine applicable clippy fixes and then fmt)
r? `@compiler-errors`
jieyouxu
added a commit
to jieyouxu/rust
that referenced
this pull request
Jan 20, 2025
…compiler-errors
Replace usages of `map_or(bool, ...)` with `is_{some_and|none_or|ok_and}`
Split out from rust-lang#135732 according to rust-lang#135732 ,
same thing but just for the compiler:
> The usage of `map_or(bool, ...)` is really hard to understand IMHO.
> This PR simply uses clippy (with `--fix`) to replace that with `is_{some_and|none_or|ok_and}`.
> (no manual modifications were made, just machine applicable clippy fixes and then fmt)
r? ``@compiler-errors``
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 20, 2025
Rollup merge of rust-lang#135738 - yotamofek:map_or_true-compiler, r=compiler-errors Replace usages of `map_or(bool, ...)` with `is_{some_and|none_or|ok_and}` Split out from rust-lang#135732 according to rust-lang#135732 , same thing but just for the compiler: > The usage of `map_or(bool, ...)` is really hard to understand IMHO. > This PR simply uses clippy (with `--fix`) to replace that with `is_{some_and|none_or|ok_and}`. > (no manual modifications were made, just machine applicable clippy fixes and then fmt) r? ``@compiler-errors``
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The usage of
map_or(bool, ...)is really hard to understand IMHO.This PR simply uses clippy (with
--fix) to replace that withis_{some_and|none_or|ok_and}.(no manual modifications were made, just machine applicable clippy fixes and then fmt)