LTA: Actually check where-clauses for well-formedness at the def site #136432
+78
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
fmease
changed the title
fmease
force-pushed
the
lta-fix-def-site-checks
branch
2 times, most recently
from
e268763 to
901450d
Compare
fmease
commented
Feb 2, 2025
| Some(WellFormedLoc::Ty(def_id)), | ||
| item_ty.into(), | ||
| ); | ||
| check_where_clauses(wfcx, item.span, def_id); |
There was a problem hiding this comment.
I've basically just added check_where_clause and inlined check_item_type. I could've made it work without inlining but that wouldn't've been super nice (it's already quite branch-y and that would've made it worse)
There was a problem hiding this comment.
Nah, check_item_type is jank and didn't really make sense since it's otherwise only used for consts/statics.
fmease
commented
Feb 2, 2025
compiler-errors
approved these changes
Feb 2, 2025
| Some(WellFormedLoc::Ty(def_id)), | ||
| item_ty.into(), | ||
| ); | ||
| check_where_clauses(wfcx, item.span, def_id); |
There was a problem hiding this comment.
Nah, check_item_type is jank and didn't really make sense since it's otherwise only used for consts/statics.
fmease
force-pushed
the
lta-fix-def-site-checks
branch
from
901450d to
c371363
Compare
|
@bors r=compiler-errors rollup (affects unstable features only) |
bors
added
S-waiting-on-bors
6 tasks
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 3, 2025
Rollup of 8 pull requests Successful merges: - rust-lang#136356 (Docs for f16 and f128: correct a typo and add details) - rust-lang#136404 (Remove a footgun-y feature / relic of the past from the compiletest DSL) - rust-lang#136432 (LTA: Actually check where-clauses for well-formedness at the def site) - rust-lang#136438 (miri: improve error when offset_from preconditions are violated) - rust-lang#136441 ([`compiletest`-related cleanups 1/7] Cleanup `is_rustdoc` logic and remove a useless path join in rustdoc-json runtest logic) - rust-lang#136455 (Remove some `Clone` bounds and derives.) - rust-lang#136464 (Remove hook calling via `TyCtxtAt`.) - rust-lang#136467 (override default config profile on tarballs) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 3, 2025
Rollup merge of rust-lang#136432 - fmease:lta-fix-def-site-checks, r=compiler-errors LTA: Actually check where-clauses for well-formedness at the def site All of the added tests used to wrongfully pass. r? oli-obk or types/compiler or reassign
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of the added tests used to wrongfully pass.
r? oli-obk or types/compiler or reassign