Stabilization for owned (now boxed) and cell
#15591
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// Returns the boxed value if it is of type `T`, or | ||
| /// `Err(Self)` if it isn't. | ||
| fn move<T: 'static>(self) -> Result<Box<T>, Self>; | ||
| fn downcast<T: 'static>(self) -> Result<Box<T>, Self>; |
There was a problem hiding this comment.
Could you leave the move method as a #[deprecated] default method for now?
|
r=me with just a few nits |
This PR is the outcome of the library stabilization meeting for the `liballoc::owned` and `libcore::cell` modules. Aside from the stability attributes, there are a few breaking changes: * The `owned` modules is now named `boxed`, to better represent its contents. (`box` was unavailable, since it's a keyword.) This will help avoid the misconception that `Box` plays a special role wrt ownership. * The `AnyOwnExt` extension trait is renamed to `BoxAny`, and its `move` method is renamed to `downcast`, in both cases to improve clarity. * The recently-added `AnySendOwnExt` extension trait is removed; it was not being used and is unnecessary. [breaking-change]
bors
added a commit
that referenced
this pull request
Jul 13, 2014
This PR is the outcome of the library stabilization meeting for the `liballoc::owned` and `libcore::cell` modules. Aside from the stability attributes, there are a few breaking changes: * The `owned` modules is now named `boxed`, to better represent its contents. (`box` was unavailable, since it's a keyword.) This will help avoid the misconception that `Box` plays a special role wrt ownership. * The `AnyOwnExt` extension trait is renamed to `BoxAny`, and its `move` method is renamed to `downcast`, in both cases to improve clarity. * The recently-added `AnySendOwnExt` extension trait is removed; it was not being used and is unnecessary. [breaking-change]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the outcome of the library stabilization meeting for the
liballoc::ownedandlibcore::cellmodules.Aside from the stability attributes, there are a few breaking changes:
ownedmodules is now namedboxed, to better represent itscontents. (
boxwas unavailable, since it's a keyword.) This willhelp avoid the misconception that
Boxplays a special role wrtownership.
AnyOwnExtextension trait is renamed toBoxAny, and itsmovemethod is renamed to
downcast, in both cases to improve clarity.AnySendOwnExtextension trait is removed; it wasnot being used and is unnecessary.
[breaking-change]