Rename Share to Sync
#16285
Closed
Rename Share to Sync
#16285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1804,7 +1804,7 @@ def_type_content_sets!( | |||
| ReachesBorrowed = 0b0000_0010__0000_0000__0000, | |||
| // ReachesManaged /* see [1] below */ = 0b0000_0100__0000_0000__0000, | |||
| ReachesMutable = 0b0000_1000__0000_0000__0000, | |||
| ReachesNoShare = 0b0001_0000__0000_0000__0000, | |||
| ReachesNoSync = 0b0001_0000__0000_0000__0000, | |||
There was a problem hiding this comment.
The = should be moved one space right.
|
r=me with the minor realignment. |
This leaves the `Share` trait at `std::kinds` via a `#[deprecated]` `pub use` statement, but the `NoShare` struct is no longer part of `std::kinds::marker` due to rust-lang#12660 (the build cannot bootstrap otherwise). All code referencing the `Share` trait should now reference the `Sync` trait, and all code referencing the `NoShare` type should now reference the `NoSync` type. The functionality and meaning of this trait have not changed, only the naming. Closes rust-lang#16281 [breaking-change]
bors
added a commit
that referenced
this pull request
Aug 8, 2014
This leaves the `Share` trait at `std::kinds` via a `#[deprecated]` `pub use` statement, but the `NoShare` struct is no longer part of `std::kinds::marker` due to #12660 (the build cannot bootstrap otherwise). All code referencing the `Share` trait should now reference the `Sync` trait, and all code referencing the `NoShare` type should now reference the `NoSync` type. The functionality and meaning of this trait have not changed, only the naming. Closes #16281 [breaking-change]
| @@ -296,7 +296,7 @@ lets_do_this! { | |||
|
|
|||
| NoSendItem, "no_send_bound", no_send_bound; | |||
| NoCopyItem, "no_copy_bound", no_copy_bound; | |||
| NoShareItem, "no_share_bound", no_share_bound; | |||
| NoSyncItem, "no_share_bound", no_share_bound; | |||
There was a problem hiding this comment.
no_share_bound wasn't updated. See #16780 which may be a mistake.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 8, 2024
fix: Fix panic on unaligned packed attribute Closes rust-lang#16284
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This leaves the
Sharetrait atstd::kindsvia a#[deprecated]pub usestatement, but the
NoSharestruct is no longer part ofstd::kinds::markerdue to #12660 (the build cannot bootstrap otherwise).
All code referencing the
Sharetrait should now reference theSynctrait,and all code referencing the
NoSharetype should now reference theNoSynctype. The functionality and meaning of this trait have not changed, only the
naming.
Closes #16281
[breaking-change]