syntax: Enable parsing of const globals
#17729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // except according to those terms. | ||
|
|
||
| const mut FOO: uint = 3; //~ ERROR: expected identifier, found keyword `mut` | ||
| //~^ ERROR: expected `:`, found `FOO` |
There was a problem hiding this comment.
This flow-on error seems unfortunate.
There was a problem hiding this comment.
(It seems sensible that const mut is actually detected and handled with a special message: "constants cannot be mutable, maybe you mean a static?")
|
r=me with handling of |
This rewrites them to the current `ItemStatic` production of the compiler, but I want to get this into a snapshot. It will be illegal to use a `static` in a pattern of a `match` statement, so all those current uses will need to be rewritten to `const` once it's implemented. This requires that the stage0 snapshot is able to parse `const`. cc rust-lang#17718
alexcrichton
force-pushed
the
issue-17718-start
branch
from
3f65e8b to
7e22af3
Compare
|
Updated with a better error message |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rewrites them to the current
ItemStaticproduction of the compiler, but Iwant to get this into a snapshot. It will be illegal to use a
staticin apattern of a
matchstatement, so all those current uses will need to berewritten to
constonce it's implemented. This requires that the stage0snapshot is able to parse
const.cc #17718