Adjust orphan rules to consider all input types, not just self type. #18223
+42
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @aturon this fixes that coherence failure we saw with the |
nikomatsakis
force-pushed
the
coherence-orphan-18222
branch
from
790c8e2 to
aeba2cc
Compare
| return ty_is_local(tcx, self_ty); | ||
| // Otherwise, at least one of the input types must be local to the | ||
| // crate. | ||
| trait_ref.input_types().iter().any(|&t| ty_is_local(tcx, t)) |
There was a problem hiding this comment.
Now that is some readable code :-)
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Oct 8, 2024
…lbasi Use external stack in borrowck DFS Because damnit, it can crash r-a. Why do people make this stupid DFSes anyway (I get it, it's easier until it blows). Fixes rust-lang#18223 (who thought DFS will be the problem).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust orphan rules to consider all input types, not just self type.
Fixes #18222.
r? @pcwalton