Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add syntax for negative implementations of traits #20285

Merged
merged 2 commits into from
Jan 5, 2015

Conversation

flaper87
Copy link
Contributor

This commit introduces the syntax for negative implementations of traits
as shown below:

impl !Trait for Type {}

cc #13231
Part of RFC rust-lang/rfcs#127

r? @nikomatsakis

@nikomatsakis
Copy link
Contributor

This looks good but I think it needs:

  • a test for pretty-printer
  • a feature-gate (oibit? rfc127?)

@flaper87 flaper87 force-pushed the oibit-send-and-friends branch from ea5ed28 to e9334ea Compare December 29, 2014 11:52
@flaper87
Copy link
Contributor Author

@nikomatsakis erm, it looks like I forgot to git add the tests I've implemented (facepalm)

@flaper87 flaper87 force-pushed the oibit-send-and-friends branch from e9334ea to 336a8e6 Compare December 29, 2014 13:05
@flaper87
Copy link
Contributor Author

@nikomatsakis I went with something a bit longer but clearer optin_builtin_traits

@nikomatsakis
Copy link
Contributor

r+ if nits are fixed and commit 336a836 is dropped

@flaper87 flaper87 force-pushed the oibit-send-and-friends branch 7 times, most recently from 04413e7 to 5fdd809 Compare December 30, 2014 20:11
@flaper87
Copy link
Contributor Author

@nikomatsakis rebased r? :)

@flaper87 flaper87 force-pushed the oibit-send-and-friends branch from 5fdd809 to 73fb1ab Compare January 3, 2015 13:05
@flaper87
Copy link
Contributor Author

flaper87 commented Jan 3, 2015

@nikomatsakis rebased r?

@flaper87 flaper87 force-pushed the oibit-send-and-friends branch from 73fb1ab to 5ee5727 Compare January 4, 2015 09:33
@flaper87 flaper87 force-pushed the oibit-send-and-friends branch from 5ee5727 to 42fe3c2 Compare January 4, 2015 14:50
This commit introduces the syntax for negative implmenetations of traits
as shown below:

`impl !Trait for Type {}`

cc rust-lang#13231
Part of RFC rust-lang#3
@flaper87 flaper87 force-pushed the oibit-send-and-friends branch from 42fe3c2 to c062fac Compare January 4, 2015 22:16
bors added a commit that referenced this pull request Jan 5, 2015
…tsakis

This commit introduces the syntax for negative implementations of traits
as shown below:

`impl !Trait for Type {}`

cc #13231
Part of RFC rust-lang/rfcs#127

r? @nikomatsakis
@bors bors merged commit c062fac into rust-lang:master Jan 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants