Various fixes to associated types #20374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
is still probably wrong since it fails to incorporate the ambiguity resolution measures that `select` uses. Also, made more complicated by the fact that trait object types do not impl their own traits yet.
|
r=me modulo nits |
…tracted from an impl are potentially in need of normalization. This also lays groundwork for further cleanup in other areas by disconnecting normalization from the fulfillment context.
nikomatsakis
force-pushed
the
assoc-types
branch
from
ffbcb72 to
6cb425d
Compare
nikomatsakis
force-pushed
the
assoc-types
branch
from
545f9a2 to
0f079c2
Compare
due to this but we were not able to isolate a smaller test case.
nikomatsakis
force-pushed
the
assoc-types
branch
from
0f079c2 to
0a2d531
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These mostly derive from problems that @japaric encountered.
r? @pcwalton