Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Any[Mut]RefExt traits in favor of impl Any #20393

Merged
merged 1 commit into from
Jan 4, 2015

Conversation

japaric
Copy link
Member

@japaric japaric commented Jan 1, 2015

Needs a snapshot that contains PR #20385

r? @aturon

@aturon
Copy link
Member

aturon commented Jan 1, 2015

This looks great to me. Did you try the same treatment in the extension trait in boxed? (Implementing it directly on Box<Any>)

@alexcrichton
Copy link
Member

For posterity, I tried to remove BoxAny in #20420, which required some compiler changes to allow inherent impls on Box inside of liballoc.

While accepted by the compiler, it ended up rejecting calling .downcast() on Box<Any + Send> in the tests of std::thread, so I had to back that part of the change out.

@aturon
Copy link
Member

aturon commented Jan 3, 2015

Needs a rebase (I believe I r+'ed a previous version?)

bors added a commit that referenced this pull request Jan 4, 2015
@bors bors merged commit 5172b80 into rust-lang:master Jan 4, 2015
@japaric japaric deleted the impl-any branch January 4, 2015 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants