Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustc: Use --extern to always override #21782

Merged
merged 1 commit into from
Feb 3, 2015

Conversation

alexcrichton
Copy link
Member

Previously if --extern was specified it would not override crates in the
standard distribution, leading to issues like #21771. This commit alters the
behavior such that if --extern is passed then it will always override any other
choice of crates and no previous match will be used (unless it is the same path
as --extern).

Closes #21771

Previously if --extern was specified it would not override crates in the
standard distribution, leading to issues like rust-lang#21771. This commit alters the
behavior such that if --extern is passed then it will always override any other
choice of crates and no previous match will be used (unless it is the same path
as --extern).

Closes rust-lang#21771
@rust-highfive
Copy link
Collaborator

r? @nick29581

(rust_highfive has picked a reviewer for you, use r? to override)

@nrc
Copy link
Member

nrc commented Feb 2, 2015

@bors r+ cf535a3

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Feb 2, 2015
Previously if --extern was specified it would not override crates in the
standard distribution, leading to issues like rust-lang#21771. This commit alters the
behavior such that if --extern is passed then it will always override any other
choice of crates and no previous match will be used (unless it is the same path
as --extern).

Closes rust-lang#21771
@bors bors merged commit cf535a3 into rust-lang:master Feb 3, 2015
@alexcrichton alexcrichton deleted the issue-21771 branch February 3, 2015 06:44
@huonw huonw mentioned this pull request Feb 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using crates.io libc triggers unstable libc warning
4 participants