Rollup PRs in the queue #21997
Merged
Rollup PRs in the queue #21997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is now a Result, not an Option.
This was particularly helpful in the time just after OIBIT's implementation to make sure things that were supposed to be Copy continued to be, but it's now creates a lot of noise for types that intentionally don't want to be Copy.
Currently "k / 2" generates one (k: uint) or two (k: int) "br false, ..." instructions and the corresponding basic blocks, producing quite some noise and making the code unnecessarily hard to read. Additionally we can skip translation if the code would end up unreachable anyway.
The spelling corrections were made in both documentation comments and regular comments.
Just spelling corrections.
…ult. The 'stable_features' lint helps people progress from unstable to stable Rust by telling them when they no longer need a `feature` attribute because upstream Rust has declared it stable. This compares to the existing 'unstable_features', which is used to implement feature staging, and triggers on *any* use of `#[feature]`.
New functions, slice::from_raw_parts and slice::from_raw_parts_mut, are added to implement the lifetime convention as agreed in RFC PR rust-lang#556. The functions slice::from_raw_buf and slice::from_raw_mut_buf are left deprecated for the time being.
- add `_SC_GETPW_R_SIZE_MAX` constant - declare `struct passwd` - convert `load_self` to `current_exe` Note: OpenBSD don't provide system function to return a valuable Path for `env::current_exe`. The implementation is currently based on the value of `argv[0]`, which couldn't be used when executable is called via PATH.
Also added test for it. Fixes rust-lang#21928
- add `std::env:consts` - deprecating `std::os::consts` - refactoring errno_location()
Only the second reference's mutability is relevant to the mutability of the returned reference.
…move this overeager code that was pruning out ambig where-clause matches in trait selection. cc rust-lang#21974.
This can be considered partial work on rust-lang#8256. The main observable change: macro expansion sometimes results in spans where `lo > hi`; so for now, when we have such a span, do not attempt to return a snippet result. (Longer term, we might think about whether we could still present a snippet for the cases where this arises, e.g. perhaps by showing the whole macro as the snippet, assuming that is the sole cause of such spans; or by somehow looking up the closest AST node that holds both `lo` and `hi`, and showing that.) As a drive-by, revised the API to return a `Result` rather than an `Option`, with better information-packed error value that should help us (and maybe also our users) identify the causes of such problems in the future. Ideally the call-sites that really want an actual snippet would be updated to catch the newly added `Err` case and print something meaningful about it, but that is not part of this PR.
(I often run `compiletest` by hand by cut-and-pasting from what `make` runs, but then I need to tweak it (cut out options) and its useful to be told when I have removed an option that is actually required, such as `--android-cross-path=path`.)
…holds cyclic structure (which the Arena API updated for dropck cannot handle).
…ance analysis. (The code was not using the main feature of Arena in the first place, since all of the `alloc` calls were on the same type.
Creating two identical static expressions involving casts of pointers to arrays caused an assertion failure in librustc_trans.
…nalysis, r=huonw Use a TypedArena rather than an Arena for the backing storage of variance analysis. (The code was not using the main feature of Arena in the first place, since all of the `alloc` calls were on the same type.)
Creating two identical static expressions involving casts of pointers to arrays caused an assertion failure in librustc_trans. cc @eddyb
The word is repeated twice in the message like
error: obsolete syntax: `:`, `&mut:`, or `&:` syntax
This removes the word syntax that appears in messages after the second colon (:).
bors
added a commit
that referenced
this pull request
Feb 6, 2015
|
💔 Test failed - auto-mac-64-opt |
Conflicts: src/libstd/collections/mod.rs
Conflicts: src/libstd/collections/mod.rs
It seems that `lang_feature_stats` was supposed to refer to `language_feature_stats` instead. r? @brson
The word is repeated twice in the message like:
error: obsolete syntax: `:`, `&mut:`, or `&:` syntax
This removes the word syntax that appears in messages after the second colon (:).
If you were still using `MaybeOwnedVector`, update your code to use `CowVec`. [breaking-change] --- We already removed `MaybeOwned` (the string equivalent) long time ago and with a much shorter deprecation period. It's time to let go.
|
⌛ Testing commit df7db97 with merge b52f898... |
|
💔 Test failed - auto-win-32-opt |
|
@bors: retry |
bors
added a commit
that referenced
this pull request
Feb 6, 2015
|
\o/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.