RUST_TEST_TASKS -> RUST_TEST_THREADS #23525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't use 'task' anymore, these are now threads. Because this changes the name of a compiler option, this is [breaking-change]
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ |
|
📌 Commit 7cbc428 has been approved by |
|
⌛ Testing commit 7cbc428 with merge 9e25ce7... |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Mar 20, 2015
…hton We don't use 'task' anymore, these are now threads. Because this changes the name of a compiler option, this is [breaking-change] I think this is small enough to not need an RFC, nor a period of accepting both. If we want to take both for a while, I can change the patch.
|
⛄ The build was interrupted to prioritize another pull request. |
Fraser999
added a commit
to Fraser999/crust
that referenced
this pull request
Jun 9, 2015
hannobraun
added a commit
to hannobraun/vndf-2016
that referenced
this pull request
Jul 13, 2015
It hasn't worked for a while and seems no longer necessary. See: rust-lang/rust#23525
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't use 'task' anymore, these are now threads.
Because this changes the name of a compiler option, this is
[breaking-change]
I think this is small enough to not need an RFC, nor a period of accepting both. If we want to take both for a while, I can change the patch.