Fix volatile / atomic ops on bools and small aggregates #23570
Conversation
|
r? @pcwalton (rust_highfive has picked a reviewer for you, use r? to override) |
dotdash
changed the title
dotdash
force-pushed
the
issue23550
branch
2 times, most recently
from
fdc53ca to
47f8724
Compare
| } | ||
|
|
||
| #[rustc_error] | ||
| fn main() {} //~ ERROR compilation successful |
There was a problem hiding this comment.
Why is this a compile-fail test and not run-pass?
Boolean values and small aggregates have a different type in args/allocas than in SSA values but the intrinsics for volatile and atomic ops were missing the necessary casts to handle that. Fixes rust-lang#23550
|
Moved the test to run-pass. |
|
@bors r+ |
|
📌 Commit d4ca1cf has been approved by |
Boolean values and small aggregates have a different type in args/allocas than in SSA values but the intrinsics for volatile and atomic ops were missing the necessary casts to handle that. Fixes #23550
|
💔 Test failed - auto-linux-32-opt |
|
@bors: retry |
Boolean values and small aggregates have a different type in args/allocas than in SSA values but the intrinsics for volatile and atomic ops were missing the necessary casts to handle that. Fixes rust-lang#23550
|
⚡ Previous build results for auto-mac-64-opt are reusable. Rebuilding only auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-win-32-nopt-t, auto-win-32-opt, auto-win-64-nopt-t, auto-win-64-opt... |
|
💔 Test failed - auto-mac-64-nopt-t |
|
@bors: retry On Sat, Mar 21, 2015 at 4:10 PM, bors [email protected] wrote:
|
Boolean values and small aggregates have a different type in args/allocas than in SSA values but the intrinsics for volatile and atomic ops were missing the necessary casts to handle that. Fixes rust-lang#23550
|
⌛ Testing commit d4ca1cf with merge 4cf4c24... |
|
💔 Test failed - auto-mac-64-nopt-t |
|
@bors: retry On Mon, Mar 23, 2015 at 12:58 AM, bors [email protected] wrote:
|
Boolean values and small aggregates have a different type in args/allocas than
in SSA values but the intrinsics for volatile and atomic ops were
missing the necessary casts to handle that.
Fixes #23550