Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate as_mut_slice methods #23721

Merged
merged 1 commit into from
Mar 28, 2015
Merged

Deprecate as_mut_slice methods #23721

merged 1 commit into from
Mar 28, 2015

Conversation

erickt
Copy link
Contributor

@erickt erickt commented Mar 25, 2015

This is technically a breaking change as it deprecates and unstables some previously stable apis that were missed in the last round of deprecations.

[breaking change]

@rust-highfive
Copy link
Collaborator

r? @pcwalton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

@bors: r+ 5ed703b

Thanks!

Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 26, 2015
This is technically a breaking change as it deprecates and unstables some previously stable apis that were missed in the last round of deprecations.

[breaking change]
erickt added a commit to erickt/rust that referenced this pull request Mar 26, 2015
This is technically a breaking change as it deprecates and unstables some previously stable apis that were missed in the last round of deprecations.

[breaking change]
erickt added a commit to erickt/rust that referenced this pull request Mar 26, 2015
This is technically a breaking change as it deprecates and unstables some previously stable apis that were missed in the last round of deprecations.

[breaking change]
@bors
Copy link
Contributor

bors commented Mar 26, 2015

⌛ Testing commit 5ed703b with merge ffcc8c4...

@bors
Copy link
Contributor

bors commented Mar 26, 2015

💔 Test failed - auto-mac-32-opt

@tamird
Copy link
Contributor

tamird commented Mar 26, 2015

failures:

---- distributions::WeightedChoice_0 stdout ----
    <anon>:12:40: 12:54 error: use of unstable library feature 'collections': use &mut s[..] instead
<anon>:12     let wc = WeightedChoice::new(items.as_mut_slice());

@erickt
Copy link
Contributor Author

erickt commented Mar 26, 2015

@bors: retry

This is technically a breaking change as it deprecates and unstables
some previously stable apis that were missed in the last round of
deprecations.

[breaking change]
@erickt
Copy link
Contributor Author

erickt commented Mar 26, 2015

@bors: r+ rollup c5b8763

@bors
Copy link
Contributor

bors commented Mar 26, 2015

📌 Commit c5b8763 has been approved by erickt

Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 26, 2015
 This is technically a breaking change as it deprecates and unstables some previously stable apis that were missed in the last round of deprecations.

[breaking change]
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 27, 2015
This is technically a breaking change as it deprecates and unstables some previously stable apis that were missed in the last round of deprecations.

[breaking change]
@bors bors merged commit c5b8763 into rust-lang:master Mar 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants