Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: change 0u32..10 to 0..10 #23745

Merged
merged 1 commit into from
Mar 28, 2015
Merged

doc: change 0u32..10 to 0..10 #23745

merged 1 commit into from
Mar 28, 2015

Conversation

oneeman
Copy link
Contributor

@oneeman oneeman commented Mar 26, 2015

Was reading the 'Looping' section of the book and was puzzled why the last example uses 0u32..10 when the others don't. Tried it out without and it seems to work, so I figured it should just be 0..10. If there is a reason it needs to be 0u32..10 it should be explained in the text (I'd offer to do it but I have no idea).

r? @steveklabnik

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Mar 26, 2015

📌 Commit dac552f has been approved by steveklabnik

@steveklabnik
Copy link
Member

This is a historical accident, as this text was written when all integers needed a suffix. Thanks!

Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 26, 2015
 Was reading the 'Looping' section of the book and was puzzled why the last example uses `0u32..10` when the others don't.  Tried it out without and it seems to work, so I figured it should just be `0..10`.  If there is a reason it needs to be `0u32..10` it should be explained in the text (I'd offer to do it but I have no idea).

r? @steveklabnik
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 27, 2015
Was reading the 'Looping' section of the book and was puzzled why the last example uses `0u32..10` when the others don't.  Tried it out without and it seems to work, so I figured it should just be `0..10`.  If there is a reason it needs to be `0u32..10` it should be explained in the text (I'd offer to do it but I have no idea).

r? @steveklabnik
@bors bors merged commit dac552f into rust-lang:master Mar 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants