syntax: Remove support for #[should_fail] #23752
Merged
+24
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @sfackler |
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
This attribute has been deprecated in favor of #[should_panic]. This also updates rustdoc to no longer accept the `should_fail` directive and instead renames it to `should_panic`.
alexcrichton
force-pushed
the
remove-should-fail
branch
from
cbb7cbf to
3752958
Compare
|
@bors r+ |
|
📌 Commit 3752958 has been approved by |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Mar 26, 2015
…brson This attribute has been deprecated in favor of #[should_panic]. This also updates rustdoc to no longer accept the `should_fail` directive and instead renames it to `should_panic`.
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Mar 27, 2015
This attribute has been deprecated in favor of #[should_panic]. This also updates rustdoc to no longer accept the `should_fail` directive and instead renames it to `should_panic`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attribute has been deprecated in favor of #[should_panic]. This also
updates rustdoc to no longer accept the
should_faildirective and insteadrenames it to
should_panic.