#fmt syntax extension #246
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I forgot, I also added a file pretty.rs to the frontend which does a very small amount of AST pretty printing that I've been using in lieu of working unit tests. I can remove that from the branch if you like. |
|
I just noticed that I accidentally turned TRACK_ALLOCATIONS on. I'll fix that tonight. |
keeperofdakeys
pushed a commit
to keeperofdakeys/rust
that referenced
this pull request
Dec 12, 2017
unix: Add openpty(3) and forkpty(3) for non-Apple platforms The functions were added for Apple in rust-lang#202. Adding them to other platforms was pending an amendment to RFC 1291 to expand the scope of libc to include libutil. The amendment was merged as rust-lang/rfcs#1529
rchaser53
pushed a commit
to rchaser53/rust
that referenced
this pull request
Jan 19, 2019
This happens every time a new doc submodule is added to https://github.com/rust-lang/rust. cc rust-lang/book#549 rust-lang/reference#36 rust-lang/rust-by-example#1018
djtech-dev
pushed a commit
to djtech-dev/rust
that referenced
this pull request
Dec 9, 2021
…ig-file Upgrade to GitHub-native Dependabot
workingjubilee
pushed a commit
to workingjubilee/rustc
that referenced
this pull request
Jul 20, 2022
Add bitmask array
ZuseZ4
pushed a commit
to EnzymeAD/rust
that referenced
this pull request
Mar 7, 2023
matthiaskrgr
pushed a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 7, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Graydon,
I've translated the #fmt syntax extension to rustc. It currently builds but doesn't pass tests. The AST it builds depends on vector addition and calls into std, neither of which work yet. Once those are completed I'm interested in fleshing this out and adding tests.
I'd particularly like you to review how I've interpreted the expr_ext AST node, to which I added a new expression parameter. I'm using it as expr_ext(path, argument_exprs, body_expr, expanded_expr, ann). The arguments and body parameters are used by the extension to generate the expanded expression, and only the expanded expression is folded and translated. The 'body' expression isn't used by #fmt.