Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct initial guessing game example. Fixes #25147. r? @steveklabnik #25148

Merged
merged 1 commit into from
May 7, 2015

Conversation

banks
Copy link
Contributor

@banks banks commented May 6, 2015

Let me know if I didn't follow correct procedure - seems a trivial change and no one that can be automatically tested.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @huonw (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented May 6, 2015

📌 Commit 81b90bd has been approved by steveklabnik

@steveklabnik
Copy link
Member

Ah yes! I was adapting the old code, and missed this one. Thanks so much!

@killercup killercup mentioned this pull request May 6, 2015
rydotyosh added a commit to rydotyosh/rust that referenced this pull request May 6, 2015
steveklabnik added a commit to steveklabnik/rust that referenced this pull request May 7, 2015
Let me know if I didn't follow correct procedure - seems a trivial change and no one that can be automatically tested.
steveklabnik added a commit to steveklabnik/rust that referenced this pull request May 7, 2015
steveklabnik added a commit to steveklabnik/rust that referenced this pull request May 7, 2015
Let me know if I didn't follow correct procedure - seems a trivial change and no one that can be automatically tested.
steveklabnik added a commit to steveklabnik/rust that referenced this pull request May 7, 2015
bors added a commit that referenced this pull request May 7, 2015
@bors bors merged commit 81b90bd into rust-lang:master May 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants