Add error explanations for E0072, E0073, E0121, E0178, E0371, E0372. #25501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
| One way to fix this is by wrapping `ByteList` in a `Box`, like so: | ||
|
|
||
| ``` | ||
| struct ByteList { |
There was a problem hiding this comment.
The name changed from ListNode to ByteList here, was that intentional?
|
You're a machine @nham! Thanks so much for these! |
|
r=me with a rebase |
|
rebased |
|
Hm, github still says it can't be merged? |
|
Doh! 😳 I squashed instead of rebasing. Didnt even see there was a merge conflict. Should be rebased now. |
|
Ahh hold on, it's still borked. |
|
Alright, my brain broke for a bit there, but it looks good now. |
bors
added a commit
that referenced
this pull request
May 18, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #24407