add error diagnostics for E0437, E0438 #27145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @pcwalton (rust_highfive has picked a reviewer for you, use r? to override) |
| "##, | ||
|
|
||
| E0407: r##" | ||
| Trait impls can only declare methods that are members of the trait in question. |
There was a problem hiding this comment.
nit: declare isn't quite right here. the trait itself "declares" the methods, and the impl implements them.
There was a problem hiding this comment.
Should "implement" be used for each of the item types (not just methods)?
|
Nits addressed. |
|
r? @Manishearth |
| Here is an example that demonstrates the error: | ||
|
|
||
| ``` | ||
| trait Foo {} |
There was a problem hiding this comment.
add a trait method in this example
|
@Manishearth Updated. |
|
☔ The latest upstream changes (presumably #27219) made this pull request unmergeable. Please resolve the merge conflicts. |
apasel422
changed the title
|
Rebased. |
|
r=me with a trait method added |
|
To which one? This PR no longer addresses E0407. |
|
@bors r+ rollup oh, okay |
|
📌 Commit cf8a163 has been approved by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.