Improve codegen for the various "with overflow" intrinsics #27962
+29
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @nrc (rust_highfive has picked a reviewer for you, use r? to override) |
We're currently possibly introducing an unneeded temporary, make use of InsertValue which is said to kick us off of FastISel and we generate loads/stores of first class aggregates, which is bad as well. Let's not do all these things.
|
⌛ Testing commit 274dae9 with merge fbc2d04... |
|
💔 Test failed - auto-linux-32-opt |
|
@bors retry |
bors
added a commit
that referenced
this pull request
Aug 23, 2015
We're currently possibly introducing an unneeded temporary, make use of InsertValue which is said to kick us off of FastISel and we generate loads/stores of first class aggregates, which is bad as well. Let's not do all these things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're currently possibly introducing an unneeded temporary, make use of
InsertValue which is said to kick us off of FastISel and we generate
loads/stores of first class aggregates, which is bad as well. Let's not
do all these things.