Make iter::order functions into methods on Iterator #27975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm personally a fan of the API changes made here, and I'm kicking off a crater build now |
|
Crater reports one regression, but it's because of |
alexcrichton
added
the
T-libs-api
|
cc @rust-lang/libs |
|
These can use IntoIterator arguments now, by the way (and should, anywhere they go). |
|
I like free functions for their symmetry in both arguments. IntoIterator emphasizes the asymmetry with methods even more. That said, these methods work too. |
This does cause some breakage due to deficiencies in resolve - `path::Components` is both an `Iterator` and implements `Eq`, `Ord`, etc. If one calls e.g. `partial_cmp` on a `Components` and passes a `&Components` intending to target the `PartialOrd` impl, the compiler will select the `partial_cmp` from `Iterator` and then error out. I doubt anyone will run into breakage from `Components` specifically, but we should see if there are third party types that will run into issues. `iter::order::equals` wasn't moved to `Iterator` since it's exactly the same as `iter::order::eq` but with an `Eq` instead of `PartialEq` bound, which doensn't seem very useful. I also updated `le`, `gt`, etc to use `partial_cmp` which lets us drop the extra `PartialEq` bound. cc rust-lang#27737
sfackler
force-pushed
the
iter-order-methods
branch
from
f4dc754 to
651c42f
Compare
|
@bors r=aturon |
|
📌 Commit 651c42f has been approved by |
bors
added a commit
that referenced
this pull request
Aug 27, 2015
This does cause some breakage due to deficiencies in resolve - `path::Components` is both an `Iterator` and implements `Eq`, `Ord`, etc. If one calls e.g. `partial_cmp` on a `Components` and passes a `&Components` intending to target the `PartialOrd` impl, the compiler will select the `partial_cmp` from `Iterator` and then error out. I doubt anyone will run into breakage from `Components` specifically, but we should see if there are third party types that will run into issues. `iter::order::equals` wasn't moved to `Iterator` since it's exactly the same as `iter::order::eq` but with an `Eq` instead of `PartialEq` bound, which doensn't seem very useful. I also updated `le`, `gt`, etc to use `partial_cmp` which lets us drop the extra `PartialEq` bound. cc #27737 r? @alexcrichton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does cause some breakage due to deficiencies in resolve -
path::Componentsis both anIteratorand implementsEq,Ord,etc. If one calls e.g.
partial_cmpon aComponentsand passes a&Componentsintending to target thePartialOrdimpl, the compilerwill select the
partial_cmpfromIteratorand then error out. Idoubt anyone will run into breakage from
Componentsspecifically, butwe should see if there are third party types that will run into issues.
iter::order::equalswasn't moved toIteratorsince it's exactly thesame as
iter::order::eqbut with anEqinstead ofPartialEqbound,which doensn't seem very useful.
I also updated
le,gt, etc to usepartial_cmpwhich lets us dropthe extra
PartialEqbound.cc #27737
r? @alexcrichton