Make the fulldeps modes independent of their respective non-fulldeps mode. #28017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
Could you describe a bit the motivation for this change as well? It doesn't look like it immediately enables much at first |
…mode. This is a change needed for rust-lang#27937, so that `-L $(llvm-config --libdir)` is only added to RUSTFLAGS for fulldeps based compiletest modes.
DiamondLovesYou
force-pushed
the
rpass-full-mode
branch
from
04795d0 to
6dae7de
Compare
|
Done. |
|
Can this just be folded directly into #27937? I'm not sure it's buying a whole lot as a standalone PR... |
|
Alright. |
|
Ok! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a change needed for #27937, so that
-L $(llvm-config --libdir)is onlyadded to RUSTFLAGS for fulldeps based compiletest modes.