Rewrite metadata indexing #28176
Merged
Rewrite metadata indexing #28176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Do you have any numbers on size/time improvements? |
|
☔ The latest upstream changes (presumably #28174) made this pull request unmergeable. Please resolve the merge conflicts. |
added 2 commits
September 3, 2015 12:23
this improves the compilation time for small crates by ~20%
|
Compiling a small crate shrinks from 410ms to 370ms. Metadata size is larger for some crates and smaller for others, but mostly smaller (librustc.rlib grows by ~560kiB, most other crates - including libstd and librustc_trans - shrink by a similar amount). |
|
@bors r+ |
|
📌 Commit cde09e7 has been approved by |
bors
added a commit
that referenced
this pull request
Sep 3, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @eddyb