Remove the deprecated box(PLACE) syntax. #28608
Conversation
|
@eddyb travis says you need to placate the pretty tests in some way. |
| cx.tcx.sess.span_bug( | ||
| self.span, | ||
| &format!("operator should have been handled elsewhere {:?}", op)); | ||
| &format!("derefence should have been handled elsewhere {:?}", op)); |
There was a problem hiding this comment.
typo: "derefence" should be "dereference" (or "deref" perhaps; its just a bug msg...)
|
cc #22181 |
|
@eddyb okay this looks fine to me (as in, r=me once travis is happy). Looks like the only issue is that your pretty printing code is inserting an extra set of |
eddyb
force-pushed
the
no-place-for-an-old-box
branch
from
a1b7132 to
f293ea2
Compare
|
@bors r=pnkfelix |
|
📌 Commit f293ea2 has been approved by |
While this is technically a [breaking-change], there is no excuse for touching `HEAP`. r? @pnkfelix
|
💔 Test failed - auto-mac-64-nopt-t |
|
@bors: retry On Thu, Sep 24, 2015 at 3:04 PM, bors [email protected] wrote:
|
|
⚡ Previous build results for auto-linux-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-win-msvc-32-opt are reusable. Rebuilding only auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-x-android-t, auto-mac-64-nopt-t, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-64-opt... |
While this is technically a [breaking-change], there is no excuse for touching
HEAP.r? @pnkfelix