Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make RandomState a lazy singleton. Fixes #27243 #28916

Closed
wants to merge 1 commit into from

Conversation

cristicbz
Copy link
Contributor

See #27243. The trick for single initialization is borrowed from lazy_static.

Creating and dropping many hash maps bench results:

before:
test collections::hash::bench::new_drop          ... bench:         102 ns/iter (+/- 5)

after:
test collections::hash::bench::new_drop          ... bench:           3 ns/iter (+/- 0)

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@cristicbz
Copy link
Contributor Author

cc @gankro since he's the one who filed the issue (and offered to mentor)

@cristicbz
Copy link
Contributor Author

Ah, so I completely missed @apasel422's #27246, d'oh... Well, take this as an alternative implementation for the per-instance option with what seem to be better benchmarks (comparable to the thread_local) one.

Sorry about that...

@cristicbz cristicbz closed this Oct 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants