Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement calling of const fn-methods in true constants #30084

Merged
merged 1 commit into from
Dec 4, 2015

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Nov 27, 2015

No description provided.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @arielb1 (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@oli-obk
Copy link
Contributor Author

oli-obk commented Dec 4, 2015

ping @arielb1

@@ -14,7 +14,7 @@
struct S(i32);

const CONSTANT: S = S(0);
//~^ ERROR: constant evaluation error: non-constant path in constant expression [E0080]
//~^ ERROR: constant evaluation error: call on struct [E0080]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(am I crazy for not understanding why this doesn't work at this point?)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clarification: What I mean by that is: Is this a deliberate design decision to make this illegal? Or is it just an artifact of the current rustc implementation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just an artifact. it works in trans/consts, but not in const_eval. It's in the queue after fixing tuples and structs.

@pnkfelix
Copy link
Member

pnkfelix commented Dec 4, 2015

@bors r+

@bors
Copy link
Contributor

bors commented Dec 4, 2015

📌 Commit 8e64e22 has been approved by pnkfelix

bors added a commit that referenced this pull request Dec 4, 2015
@bors
Copy link
Contributor

bors commented Dec 4, 2015

⌛ Testing commit 8e64e22 with merge 68c15be...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants