resolve: Refactor away record_exports, fixing #4953 #30864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @nrc |
| None => return, | ||
| }; | ||
| self.resolver.export_map.entry(node_id).or_insert(Vec::new()).push(export); | ||
| } |
There was a problem hiding this comment.
Could you move the if public check into add_export
|
Wow, nice. r+ with the tiny bit of refactoring |
jseyfried
force-pushed
the
no_record_exports
branch
from
02226ed to
d3561d4
Compare
|
@nrc Thanks for the feedback. I moved the public check into add_export and amended the commit. |
|
@bors: r+ |
|
📌 Commit d3561d4 has been approved by |
|
☔ The latest upstream changes (presumably #30883) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added a commit
that referenced
this pull request
Jan 14, 2016
jseyfried
force-pushed
the
no_record_exports
branch
from
d3561d4 to
a353490
Compare
|
@nrc Rebased |
|
@bors: r+ |
|
📌 Commit a353490 has been approved by |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jan 15, 2016
bors
added a commit
that referenced
this pull request
Jan 15, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.