Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

first round of removal of integer suffixes #32177

Merged
merged 2 commits into from
Mar 28, 2016
Merged

first round of removal of integer suffixes #32177

merged 2 commits into from
Mar 28, 2016

Conversation

srinivasreddy
Copy link
Contributor

No description provided.

@steveklabnik
Copy link
Member

🤘

@alexcrichton
Copy link
Member

Looks like some tests are failing, but otherwise

r? @steveklabnik

@srinivasreddy srinivasreddy changed the title [WIP] - first round of removal of integer suffixes first round of removal of integer suffixes Mar 10, 2016
oli-obk
oli-obk reviewed Mar 11, 2016
View reviewed changes
src/libcollectionstest/slice.rs
@@ -1287,7 +1287,7 @@ mod bench {
#[bench]
fn zero_1kb_from_elem(b: &mut Bencher) {
b.iter(|| {
vec![0u8; 1024]
vec![0; 1024]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't this change from 1kb to 4kb? because it's inferred to i32 now

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this one should stay.

@srinivasreddy srinivasreddy mentioned this pull request Mar 11, 2016
Closed
@srinivasreddy
Copy link
Contributor Author

ping @steveklabnik . Please include this and roll up again :)

@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Mar 28, 2016

📌 Commit 91a42be has been approved by steveklabnik

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Mar 28, 2016
@steveklabnik
Rollup merge of rust-lang#32177 - srinivasreddy:remove_integer_suffix…
f2c6b51 
…es, r=steveklabnik

 first round of removal of integer suffixes
@steveklabnik steveklabnik mentioned this pull request Mar 28, 2016
Merged
bors added a commit that referenced this pull request Mar 28, 2016
@bors
Auto merge of #32561 - steveklabnik:rollup, r=steveklabnik
221c940 
Rollup of 7 pull requests

- Successful merges: #32177, #32235, #32472, #32504, #32507, #32509, #32534
- Failed merges:
@bors bors merged commit 91a42be into rust-lang:master Mar 28, 2016
@srinivasreddy srinivasreddy deleted the remove_integer_suffixes branch March 29, 2016 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@steveklabnik steveklabnik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@srinivasreddy @steveklabnik @alexcrichton @bors @oli-obk