Adds data race in docs #32815
Adds data race in docs #32815
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
Hi, thanks for the PR! Could squash your commits please? |
| @@ -174,7 +174,7 @@ fn main() { | |||
|
|
|||
| for i in 0..3 { | |||
There was a problem hiding this comment.
If i isn't being used we should try for _ in 1..3
There was a problem hiding this comment.
i is used (it's set to data[0]).
|
@bors delegate=GuillaumeGomez |
|
✌️ @GuillaumeGomez can now approve this pull request |
|
@GuillaumeGomez |
|
@bors: r+ rollup |
|
📌 Commit 4d8fac0 has been approved by |
Adds data race in docs Thanks for all your hard work! This is in reference to rust-lang#32733 I know there has been a discussion about this on PR rust-lang#32538 so you are welcome to keep the code as is or merge my documentation in. Let me know what you think and/or if you want me to modify anything!
Adds data race in docs Thanks for all your hard work! This is in reference to rust-lang#32733 I know there has been a discussion about this on PR rust-lang#32538 so you are welcome to keep the code as is or merge my documentation in. Let me know what you think and/or if you want me to modify anything!
Thanks for all your hard work!
This is in reference to #32733
I know there has been a discussion about this on PR #32538 so you are welcome to keep the code as is or merge my documentation in.
Let me know what you think and/or if you want me to modify anything!