-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
librustc_back: fix incorrect comment about RUST_TARGET_PATH #32856
Conversation
The path `/etc/rustc/` is not the default last entry in RUST_TARGET_PATH. This was in RFC131 but was never implemented in rustc so it was removed as part of rust-lang#31117 and rust-lang/rfcs#1473. Signed-off-by: Doug Goldstein <[email protected]>
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Do I need to rebase this change or anything? It should cleanly rebase. |
Nah so long as this cleanly merges bors will get around to it eventually. You can see the queue here as well |
@bors: rollup |
…hton librustc_back: fix incorrect comment about RUST_TARGET_PATH The path `/etc/rustc/` is not the default last entry in RUST_TARGET_PATH. This was in RFC131 but was never implemented in rustc so it was removed as part of rust-lang#31117 and rust-lang/rfcs#1473. Signed-off-by: Doug Goldstein <[email protected]>
⌛ Testing commit a4579c5 with merge a41b4e5... |
💔 Test failed - auto-win-msvc-64-opt-rustbuild |
@bors: retry On Thu, Apr 14, 2016 at 12:38 PM, bors [email protected] wrote:
|
The path
/etc/rustc/
is not the default last entry inRUST_TARGET_PATH. This was in RFC131 but was never implemented in rustc
so it was removed as part of #31117 and rust-lang/rfcs#1473.
Signed-off-by: Doug Goldstein [email protected]