Rollup of 10 pull requests #33948
Closed
Rollup of 10 pull requests #33948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
GuillaumeGomez
commented
May 29, 2016
GuillaumeGomez
commented
- Successful merges: Fix compile_fail tag #33793, Added examples/docs to split in str.rs #33893, save-temps was moved under the -C switch #33902, Improve E0132 error explanation #33912, Improve E0133 error explanation #33913, Improve err expl #33914, rustfmt liballoc folder #33917, run rustfmt on librustc_lint folder #33931, run rustfmt on librand folder #33937, run rustfmt on libunwind #33938
- Failed merges:
…expected to and was still considered 'ok') * Fix error explanations tests/tags
Added documentation clarifying the behavior of split when used with the empty string and contiguous separators.
|
@bors: r+ p=1 |
|
📌 Commit 1aaa7b2 has been approved by |
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
💔 Test failed - auto-linux-64-opt-rustbuild |
…laumeGomez Fix compile_fail tag Fixes rust-lang#33780 r? @steveklabnik
…uillaumeGomez Added examples/docs to split in str.rs Added documentation clarifying the behavior of split when used with the empty string and contiguous separators. Addresses issue [33882](rust-lang#33882). This is my first time contributing to rust, so forgive me if I'm skipping any of the contribution steps. Fixes rust-lang#33882
…veklabnik Improve E0132 error explanation r? @steveklabnik
…llaumeGomez Improve E0133 error explanation r? @steveklabnik
…GuillaumeGomez Improve err expl r? @steveklabnik
…uillaumeGomez rustfmt liballoc folder
…umeGomez run rustfmt on librustc_lint folder
…illaumeGomez run rustfmt on librand folder
…Manishearth run rustfmt on libunwind
|
@bors: r+ p=1 |
|
📌 Commit 59aef48 has been approved by |
|
⌛ Testing commit 59aef48 with merge a5f2818... |
|
💔 Test failed - auto-win-gnu-32-opt-rustbuild |
|
☔ The latest upstream changes (presumably #33929) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.